java - How to end transactions in progress properly and to close the database in Android? -


i develop simple application in android. execute time stopped unfortunately , throw error these

a sqliteconnection object database '/data/data/com.h2o/databases/mydbname.db' leaked! please fix application end transactions in progress , close database when no longer needed.

what avoid above error

here db code:

public class dbhelper extends sqliteopenhelper {      public static final string database_name = "mydbname.db";     public static final string address_table_name = "address";     public static final string address_column_id = "id";     public static final string address_column_addresstype = "addrtype";     public static final string address_column_line1 = "line1";     public static final string address_column_line2 = "line2";     public static final string address_column_city = "city";     public static final string address_column_zipcode = "zipcode";     public static final string address_column_country = "country";     public static final string address_column_state = "state";     public static final string address_column_landmark = "landmark";        //private hashmap hp;      public dbhelper(context context)     {         super(context, database_name, null, 1);     }      @override     public void oncreate(sqlitedatabase db) {         // todo auto-generated method stub         db.execsql(                 "create table address " +                         "(id integer primary key autoincrement,addrtype text not null unique, line1 text not null,line2 text not null,city text not null,zipcode text not null, country textnot null,state text not null,landmark text)"         );        }      @override     public void onupgrade(sqlitedatabase db, int oldversion, int newversion) {         // todo auto-generated method stub         db.execsql("drop table if exists address");          oncreate(db);      }      public boolean insertaddress(string addrtype, string line1, string line2, string city, string zipcode, string country, string state, string landmark)     {          sqlitedatabase db;          db= this.getwritabledatabase();         contentvalues contentvalues = new contentvalues();         contentvalues.put("addrtype", addrtype);         contentvalues.put("line1", line1);         contentvalues.put("line2", line2);         contentvalues.put("city", city);         contentvalues.put("zipcode", zipcode);         contentvalues.put("country", country);         contentvalues.put("state", state);         contentvalues.put("landmark", landmark);          string selectquery = "select * address addrtype ='"+addrtype+"'";         cursor cursor = db.rawquery(selectquery,null);          if (cursor.getcount()==1){              db.update("address",contentvalues,"addrtype ='"+addrtype+"'",null);             return true;         }         else {              db.insert("address", null, contentvalues);             return true;         }      }       public cursor getdata(int id){         sqlitedatabase db = this.getreadabledatabase();         cursor res =  db.rawquery( "select * address id="+id+"", null );         return res;     }      public int numberofrows(){         sqlitedatabase db = this.getreadabledatabase();         int numrows = (int) databaseutils.querynumentries(db, address_table_name);         return numrows;     }      public boolean updateaddress (integer id,string addrtype, string line1, string line2, string city, string zipcode,string country,string state,string landmark)     {         sqlitedatabase db = this.getwritabledatabase();         contentvalues contentvalues = new contentvalues();         contentvalues.put("addrtype", addrtype);         contentvalues.put("line1", line1);         contentvalues.put("line2", line2);         contentvalues.put("city", city);         contentvalues.put("zipcode", zipcode);         contentvalues.put("country", country);         contentvalues.put("state", state);         contentvalues.put("landmark", landmark);         db.update("address", contentvalues, "id = ? ", new string[] { integer.tostring(id) } );         return true;     }      public integer deleteaddress (integer id)     {         sqlitedatabase db = this.getwritabledatabase();         return db.delete("address",                 "id = ? ", new string[] { integer.tostring(id) });     }      public arraylist<string> getalladdress()     {         arraylist<string> array_list = new arraylist<string>();          //hp = new hashmap();         sqlitedatabase db = this.getreadabledatabase();         cursor res =  db.rawquery( "select * address", null );         res.movetofirst();          while(res.isafterlast() == false){             array_list.add(res.getstring(res.getcolumnindex(address_column_addresstype)));             res.movetonext();         }         return array_list;     }    }

addressfragment.java:

mydb = new dbhelper(this.getactivity());  cursor rs = mydb.getdata(value);                 id_to_update = value;                  rs.movetofirst();                 string addr_type = rs.getstring(rs.getcolumnindex(dbhelper.address_column_addresstype));                 string addr_line1 = rs.getstring(rs.getcolumnindex(dbhelper.address_column_line1));                 string addr_line2 = rs.getstring(rs.getcolumnindex(dbhelper.address_column_line2));                 string addr_city = rs.getstring(rs.getcolumnindex(dbhelper.address_column_city));                 string addr_zipcode = rs.getstring(rs.getcolumnindex(dbhelper.address_column_zipcode));                 addr_country_index = rs.getstring(rs.getcolumnindex(dbhelper.address_column_country));                 addr_state_index = rs.getstring(rs.getcolumnindex(dbhelper.address_column_state));                 string addr_landmark = rs.getstring(rs.getcolumnindex(dbhelper.address_column_landmark));                  if (!rs.isclosed())                 {                     rs.close();                     mydb.close();                 }

please fix it!

thanks in advance

i think getting error because not closing 'cursor' object. each cursor should closed when you're finished it. safe way is:

cursor res =  db.rawquery( "select * address", null);     try {         // read data cursor in here     } {         res.close();     }

Comments

Post a Comment

Popular posts from this blog

html - Outlook 2010 Anchor (url/address/link) -

i'm trying link specific pdf page msoutlook'10 or msword'10, #page=... anchor particularly useful , works fine elsewhere. unfortunately when click [ctr-k] in outlook or winword, links re-formatted assuming unc path. pdf file located on shared drive. using "file:" prefix links open pdf in adobe reader (outside of browser), , "http:" open inside browser. issue seem need open in browser "file:" prefix in order anchor work. know anchors work inside browser. outlook uses windows/explorer default program (based on file extension) seems open in adobe reader neglecting anchor. is aware of solution, link specific page or bookmark of shared-pdf ms outlook and/or winword link? common references: mailermailer.com/...anchor-tags-html-emails campaignmonitor.com/...anchor-links-in-email-newsletters/ stackoverflow.com/...anchor-in-pdf-document
Read more

javascript - Why does running this loop 9 times take 100x longer than running it 8 times? -

consider code: test = function() { } t = new test(); (var = 0; < 8; i++) { result = t instanceof test; } if change number of iterations 8 9 , loop take 100 times longer complete in latest version of firefox (41.0.1). tested on 2 different pcs , magic limit 8. here jsperf test used: http://jsperf.com/instanceof-8-times-vs-9-times does have idea why might happen? seems specific instanceof . not happen if else object, example check property. note: filed bugzilla bug this. jan de mooij mozilla team has posted details in bugzilla thread . here's simplistic interpretation of highly technical answers: in i < 8 case, firefox smart enough hoist result = t instanceof test; statement out of loop (according tests, doesn't seem omit altogether). in i < 9 case, apparently doesn't optimization . why? reason not clear, related fact 9 iterations threshold above function considered "hot" enough run through jit compiler. i < 8 cas...
Read more

Getting gateway time-out Rails app with Nginx + Puma running on Digital Ocean -

following this guide setup app on digital ocean droplet, not working. site not loading , it's throwing: "gateway time-out". the puma server works, since ps aux | grep puma prints: root 15878 0.0 0.4 376832 2168 ? sl 12:50 0:00 puma 2.13.4 (unix:///var/www/myapp/shared/tmp/sockets/myapp-puma.sock) [20150930164940] root 15881 0.0 0.7 903676 3692 ? sl 12:50 0:06 puma: cluster worker 0: 15878 [20150930164940] root 24654 0.0 0.1 11748 916 pts/2 s+ 18:00 0:00 grep --color=auto puma my nginx config: user root; worker_processes 1; events { worker_connections 1024; } http { upstream puma { server unix:///var/www/myapp/shared/tmp/sockets/myapp-puma.sock; } server { listen 80; server_name myapp.com; root /var/www/myapp/current/public; access_log /var/www/myapp/current/log/access.log; error_log /...
Read more